Tighten up minutes identification, add test #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
commented
Jan 16, 2025
Comment on lines
+602
to
+605
| if all( | ||
| substr in cover_page_text.lower() | ||
| for substr in (name.lower(), "minutes") | ||
| ): |
hancush
commented
Jan 16, 2025
| assert "{} already exists as a key".format(event_key) in str(excinfo.value) | ||
|
|
||
|
|
||
| def test_multiple_minutes_candidates_handling(event_scraper, api_event): |
xmedr
approved these changes
Jan 16, 2025
Comment on lines
+602
to
+605
| if all( | ||
| substr in cover_page_text.lower() | ||
| for substr in (name.lower(), "minutes") | ||
| ): |
Comment on lines
+1
to
+4
| { | ||
| "EventId": 2907, | ||
| "EventGuid": "01EE5D79-B958-46F9-B8EB-384B745A57EC", | ||
| "EventLastModifiedUtc": "2024-09-21T00:49:38.617", |
There was a problem hiding this comment.
Always a fan of more data to test with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This title addresses the bug in Metro-Records/la-metro-councilmatic#1196
Namely, when there are multiple attachments to a matter representing the approval of minutes, it looks for both "minutes" and the name of the meeting body whose minutes we're looking for on the first page.
I also added a test, using the event with an error as fixture data, since it's a great test case.
Testing Instructions