Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three Rivers Park District Theodore Wirth Request #3

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ravenmcknight
Copy link
Collaborator

@ravenmcknight ravenmcknight commented Sep 27, 2023

Description

This PR creates a new folder, follow_up_requests, with one completed request for Three Rivers Park District. The script follow_up_requests/trpd-wirth-home-locations/theodore_wirth_agency_percentages.R aggregates estimated home locations for visitors to Theodore Wirth Regional Park into several regions of interest, such implementing agency boundaries, suburban Hennepin County, etc. The results are written to an excel workbook with a metadata sheet in the same folder.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature

Courtesy checklist

  • styler:::style_active_pkg()
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have tagged this PR appropriatley

@ravenmcknight ravenmcknight added the enhancement New feature or request label Sep 27, 2023
@ravenmcknight ravenmcknight marked this pull request as ready for review September 27, 2023 16:14
@ravenmcknight
Copy link
Collaborator Author

Hi @eroten! I think this one is pretty straightforward.

One thing to note is that I read the implementing agency boundaries from a shapefile on the N drive (line 58) because I can’t currently connect to GISLibrary through R (issue with my machine, working to get it fixed with IS). Please feel free to change that if you’d rather this use the councilR function to access GISLibrary.

Thanks again for getting this started!

@eroten
Copy link
Collaborator

eroten commented Sep 27, 2023

@ravenmcknight Do you recall how the agency boundaries were created? I'd prefer we have that instead of a full path

@ravenmcknight
Copy link
Collaborator Author

@eroten The agency boundaries should be the equivalent of reading the “RegionalParksSystemImplementingAgencies” layer from GISLibrary. I’m just now realizing that this is the only data across the whole repo that would not be accessible to someone outside of the Council, though. Would it make sense to save a copy to data-raw and read it from there? I couldn’t find the agency boundaries on Geospatial Commons or anywhere else public, so I’m not sure about “publishing” it here.

@eroten
Copy link
Collaborator

eroten commented Sep 27, 2023

@ravenmcknight, thats a good point. Could we replicate the data manually using the city boundaries and county boundaries? We should be able to use an st_difference() to cut out MPRB and Bloomington from Hennepin County and St. Paul from Ramsey County. That can be done entirely with data from {tigris}, so will be reproducible outside the Council. We would save the code to make the dataset, but not have to save the dataset itself.

@ravenmcknight
Copy link
Collaborator Author

@eroten ah yes, I like that! I can put that together a little later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants