Change BetterPopup into a Control-based one #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
popup-fix
branch
9 times, most recently
from
f30e662 to
1a8310b
Compare
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605
Adds two stacks, one for overlays, one for popups. This should for the most part make the GodSVG experience nicer by sending you back one step when you press Esc or click outside a popup, instead of removing everything.
It also seems to prevent some nastiness that came from using Popup, like blurry fonts.
A small extra: Broken file icon now shows in more situations.