Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/loading indicator and widget tests #13

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Feat/loading indicator and widget tests #13

merged 3 commits into from
Aug 30, 2023

Conversation

MhouneyLH
Copy link
Owner

@MhouneyLH MhouneyLH commented Aug 30, 2023 •
edited
Loading

Summary

  • add widget tests for the available widgets and pages
  • add loading indicator

Other

  • I skipped the color parts (only for desk animation I checked the color) -> too much work for now
  • these tests can be much better I guess (this is the first time I did this) but for now it is enough (hopefully^^)

@MhouneyLH
feat: add own LoadingIndicator
a3adf13
@MhouneyLH
feat: add tests for the single widgets
abb7ca3
@MhouneyLH
feat: add remaining tests
ba662e2 
I guess these tests could be way more better, but for now it should be enough
@MhouneyLH MhouneyLH added enhancement New feature or request test labels Aug 30, 2023
@MhouneyLH MhouneyLH self-assigned this Aug 30, 2023
MhouneyLH
MhouneyLH commented Aug 30, 2023
View reviewed changes
Copy link
Owner Author

@MhouneyLH MhouneyLH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MhouneyLH MhouneyLH merged commit 112bfc2 into develop Aug 30, 2023
4 of 5 checks passed
@MhouneyLH MhouneyLH deleted the feat/loading_indicator_and_widget_tests branch August 30, 2023 15:03
@notion-workspace
Copy link

👷🏻 Widget-Tests hinzufügen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MhouneyLH MhouneyLH

Labels
enhancement New feature or request test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MhouneyLH