make cargo lock updater keep outpath links in temporary directory #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Mar 6, 2024
nix_update/update.py
Outdated
| @@ -163,10 +163,14 @@ def update_cargo_deps_hash(opts: Options, filename: str, current_hash: str) -> N | |||
| def update_cargo_lock( | |||
| opts: Options, filename: str, dst: CargoLockInSource | CargoLockInStore | |||
| ) -> None: | |||
| tempdir = tempfile.TemporaryDirectory() | |||
There was a problem hiding this comment.
In the event of a build failure this would not cleanup tempdir unless with tempdir: is used. So we need to --no-out-link to nix build to skip the symlink all together or add a large with statement.
There was a problem hiding this comment.
I considered both options and --no-out-link made me worry about GC races, but I am fine to add the with statement (it was a bigger diff and it was already leaving them everywhere, so I didn't initially do that)
I'll push the with tempfile.TemporaryDirectory() as tempfile: version sometime in the next hour or two
Thank you!
lilyinstarlight
force-pushed
the
fix/cargo-lock-leaving-result-links-everywhere
branch
from
97b7ebc to
f80ee70
Compare
lilyinstarlight
deleted the
fix/cargo-lock-leaving-result-links-everywhere
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running
nix-updateon cargo lock packages leaving result links laying around