Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEF-1652152 [Azure][FS][Parallel] Timeout field value has no effect #95

Merged
merged 8 commits into from
Mar 6, 2025
6 changes: 3 additions & 3 deletions PSModule/AbstractLauncherTaskCmdlet.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* MIT License https://github.com/MicroFocus/ADM-TFS-Extension/blob/master/LICENSE
*
* Copyright 2016-2024 Open Text
* Copyright 2016-2025 Open Text
*
* The only warranties for products and services of Open Text and its affiliates and licensors ("Open Text") are as may be set forth in the express warranty statements accompanying such products and services.
* Nothing herein should be construed as constituting an additional warranty.
Expand Down Expand Up @@ -197,12 +197,12 @@ protected override void ProcessRecord()
}
}
}
if (runStatus != RunStatus.CANCELED && _rptPaths.Any() && _enableFailedTestsReport)
if (runStatus != RunStatus.CANCELED && _rptPaths.Any())
{
//run junit report converter
string outputFileReport = Path.Combine(resdir, JUNIT_REPORT_XML);
RunConverter(converterPath, outputFileReport);
if (File.Exists(outputFileReport) && new FileInfo(outputFileReport).Length > 0 && nrOfTests[H.FAIL] > 0)
if (_enableFailedTestsReport && nrOfTests[H.FAIL] > 0 && File.Exists(outputFileReport) && new FileInfo(outputFileReport).Length > 0)
{
H.ReadReportFromXMLFile(outputFileReport, true, out IList<KeyValuePair<string, IList<ReportMetaData>>> failedSteps);
H.CreateFailedStepsReport(failedSteps, resdir);
Expand Down
3 changes: 2 additions & 1 deletion PSModule/InvokeAlmLabManagementTaskCmdlet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,8 @@ private RunManager GetRunManager(string rptPath)
ServerUrl = ALMServerPath,
Duration = TimeslotDuration,
EntityId = ALMEntityId,
RunType = TestRunType
RunType = TestRunType,
EnvironmentConfigurationId = EnvironmentConfigurationID
};
var cred = new Credentials(IsSSO, IsSSO ? ClientID : ALMUserName, IsSSO ? ApiKeySecret : ALMPassword);
bool isDebug = (ActionPreference)GetVariableValue("DebugPreference") != ActionPreference.SilentlyContinue;
Expand Down
2 changes: 1 addition & 1 deletion PSModule/InvokeFSTaskCmdlet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public override Dictionary<string, string> GetTaskProperties()
LauncherParamsBuilder builder = new();

builder.SetRunType(RunType.FileSystem);
builder.SetPerScenarioTimeOut(Timeout);
builder.SetFsTimeOut(Timeout);

var tests = TestsPath.Split("\n".ToArray());

Expand Down
6 changes: 3 additions & 3 deletions PSModule/LauncherParamsBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class LauncherParamsBuilder
private const string RUNTESTTYPE = "RunTestType";
private const string ALMTESTSETS = "almTestSets";
private const string ALMRUNHOST = "almRunHost";
private const string PERSCENARIOTIMEOUT = "PerScenarioTimeOut";
private const string FSTIMEOUT = "fsTimeout";
private const string MOBILEHOSTADDRESS = "MobileHostAddress";
private const string MOBILEUSERNAME = "MobileUserName";
private const string MOBILEPASSWORD = "MobilePassword";
Expand Down Expand Up @@ -246,9 +246,9 @@ public void SetTest(int index, string test)
SetParamValue($"Test{index}", test);
}

public void SetPerScenarioTimeOut(string perScenarioTimeOut)
public void SetFsTimeOut(string fsTimeOut)
{
SetParamValue(PERSCENARIOTIMEOUT, perScenarioTimeOut.IsNullOrWhiteSpace() ? C.MINUS_ONE : perScenarioTimeOut);
SetParamValue(FSTIMEOUT, fsTimeOut.IsNullOrWhiteSpace() ? C.MINUS_ONE : fsTimeOut);
}

public void SetDigitalLabSrvConfig(ServerConfigEx config)
Expand Down
6 changes: 3 additions & 3 deletions PSModule/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* MIT License https://github.com/MicroFocus/ADM-TFS-Extension/blob/master/LICENSE
*
* Copyright 2016-2024 Open Text
* Copyright 2016-2025 Open Text
*
* The only warranties for products and services of Open Text and its affiliates and licensors ("Open Text") are as may be set forth in the express warranty statements accompanying such products and services.
* Nothing herein should be construed as constituting an additional warranty.
Expand All @@ -20,7 +20,7 @@
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("OpenText")]
[assembly: AssemblyProduct("PSModule")]
[assembly: AssemblyCopyright("Copyright 2016-2024 Open Text")]
[assembly: AssemblyCopyright("Copyright 2016-2025 Open Text")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]

Expand All @@ -42,5 +42,5 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2024.2.0.2")]
[assembly: AssemblyVersion("2025.2.0.0")]
//[assembly: AssemblyFileVersion("2.0.0.0")]
1 change: 1 addition & 0 deletions UFTBuildTask/AlmLabManagementTask/localTask.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ $varProject = Get-VstsInput -Name 'varProject' -Require
$varRunType = Get-VstsInput -Name 'varRunType'
$varDescription = Get-VstsInput -Name 'varDescription'
$varTimeslotDuration = Get-VstsInput -Name 'varTimeslotDuration' -Require
$varEnvironmentConfigurationID = Get-VstsInput -Name 'varEnvironmentConfigurationID'
$varClientType = Get-VstsInput -Name 'varClientType'
$varReportName = Get-VstsInput -Name 'varReportName'
[string]$tsPattern = Get-VstsInput -Name 'tsPattern'
Expand Down
6 changes: 3 additions & 3 deletions UFTBuildTask/ParallelRunnerTask/localTask.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ using namespace PSModule.UftMobile.SDK.Entity
using namespace System.Collections.Generic

param()
$testPathInput = Get-VstsInput -Name 'testPathInput' -Require
$timeOutIn = Get-VstsInput -Name 'timeOutIn'
$testPathInput = (Get-VstsInput -Name 'testPathInput' -Require).Trim()
$timeOutIn = (Get-VstsInput -Name 'timeOutIn').Trim()
$uploadArtifact = Get-VstsInput -Name 'uploadArtifact' -Require
$artifactType = Get-VstsInput -Name 'artifactType'
$rptFileName = Get-VstsInput -Name 'reportFileName'
$rptFileName = (Get-VstsInput -Name 'reportFileName').Trim()
[bool]$enableFailedTestsRpt = Get-VstsInput -Name 'enableFailedTestsReport' -AsBool
[string]$tsPattern = Get-VstsInput -Name 'tsPattern'

Expand Down
2 changes: 1 addition & 1 deletion UFTBuildTask/ParallelRunnerTask/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"version": {
"Major": 6,
"Minor": 0,
"Patch": 0
"Patch": 1
},
"helpUrl": "https://admhelp.microfocus.com/uft/en/latest/UFT_Help/Content/UFT_Tools/Azure_DevOps_Extension/uft-azure-devops-run-local.htm",
"demands": "UFT_LAUNCHER",
Expand Down
Binary file modified bin/PSModule.dll
Binary file not shown.
Binary file modified installation/UFT.zip
Binary file not shown.