Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the feature that exactly matches a classname containing hyphens, then look for part-matches if no exact match found. #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SusanJaneNZ
Copy link
Contributor

To ensure the correct feature is found, first search for an exact match of feature description and classname. Only if this is not successful does the current logic to check for part matches (excluding hyphenated suffix) apply.

@bingyujin
Copy link
Contributor

@SusanJaneNZ Thank you for your pull request! We are currently working on this issue, and it will be released in the coming days.

@SusanJaneNZ
Copy link
Contributor Author

SusanJaneNZ commented May 9, 2024 via email

@bingyujin
Copy link
Contributor

bingyujin commented May 10, 2024

Thank you. Are you able to share a link to the github branch you have your fix on? Also - could you please release this fix on its own, and not packaged with other fixes? I have several issues with bdd2octane at the moment and it is extremely confusing to have fixes, part-fixes, and new bugs all introduced in one version release (I am currently beta testing the 1.1.8 jar provided). One fix per release would be incredibly helpful. Regards, Susan.

On Thu, May 9, 2024 at 3:21 PM bingyujin @.> wrote: @SusanJaneNZ https://github.com/SusanJaneNZ Thank you for your pull request! We are currently working on this issue, and it will be released in the coming days. — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGL5NMAGKBMZC7BMWWNYFS3ZBLTSNAVCNFSM6AAAAABHCYMXBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRHA3DCMJZHA . You are receiving this because you were mentioned.Message ID: @.>

hi, the fix is in #25
please use this jar to have a test.
bdd2octane.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants