-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quick-protection-app-initialization-cpp.md #1529
base: main
Are you sure you want to change the base?
Conversation
@ShannonLeavitt currently waiting on employer approval for the CLA. Shouldn't be too long! |
@microsoft-github-policy-service agree company="D. E. Shaw & Co., L.P." |
@lvkv : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@ShannonLeavitt good to go! |
IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Any updates on this? |
Can you review this old PR? @MicrosoftDocs/public-repo-pr-review-team |
Hi, just checking in! I’d like to point teammates at these docs for onboarding, but it’s hard to do that when these intro examples don’t compile |
Hi team Azure! Just like #1426 and #1412, I've made a number of changes to the MIP SDK's C++ Quickstarts.
Note that these changes are necessary to compile and run your quickstart. As it currently currently written, your code does not compile because of typos, mismatched variable names, and other errors. These changes fix it all:
mAppInfo
toappInfo
mipContext.Shutdown()
tomipContext->ShutDown()
(note the->
and capitalD
)I've also made a number of sorely-needed improvements to the readability of this document:
ReleaseAllResources()
, which appears to be a C# method that was accidentally copy-pasted herestd::foo
andmip::foo
namespace qualification whenusing foo;
was already specified. For example, the current documentation specifiesusing std::make_shared;
, then proceeds to call it with a qualifyingstd::
anyways... this appears to be because of copy-pastingusing
directives; this has the added benefit of putting the more importantusing mip::
directives above the less importantstd
onesauto
type specifiers instead of the current, seemingly random mixture ofauto
and non-auto
'\n'
newline instead of the confusing"'\n"
seen hereFinally, I've compiled and tested these changes on Windows and Linux, and feel free to ask questions and/or request changes. Thanks again for the work you've put into MPIP/AIP/RMS!