Update configure-monitoring.md #102112
Update configure-monitoring.md #102112
Conversation
Calling out how category names are chosen to contrast with other frameworks. This was confusing to me and I thought a little more explicitness might help. Also updated the first example for host.json settings to reflect [Issue 1182](Azure/azure-functions-dotnet-worker#1182).
|
@microsoft-github-policy-service agree |
|
@rellis-of-rhindleton : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit eeff32a:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/azure-functions/configure-monitoring.md | Details |
articles/azure-functions/configure-monitoring.md
- Line 68, Column 60: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#solutions-with-high-volume-of-telemetry' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 70, Column 72: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/azure-functions/functions-host-json#override-hostjson-values' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 68, Column 60: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#solutions-with-high-volume-of-telemetry' will be broken in isolated environments. Replace with a relative link. - Line 70, Column 72: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/azure-functions/functions-host-json#override-hostjson-values' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Note that the links are both absolute and contain hard-coded locals. Both of these issues will need be addressed before we can merge. (we can help with this if you'd like - and approve the content changes) #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Didn't think about that. If you can tell me how links should be structured I can fix. |
There was a problem hiding this comment.
Thanks @rellis-of-rhindleton for helping out. Please accept my suggestions to fix the link issues.
@brettsam to verify the updates.
Co-authored-by: Glenn Gailey <[email protected]>
|
@rellis-of-rhindleton : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Co-authored-by: Glenn Gailey <[email protected]>
|
@rellis-of-rhindleton : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Thanks @rellis-of-rhindleton for helping out with this...it keeps me from having to stash a bunch of stuff on my machine 😉 |
|
If my contribution to open source is just bits and pieces of documentation pages here and there, I'm fine with that. |
|
Learn Build status updates of commit 9b5574e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit e2ece1d: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
emailed GG |
|
emailed author |
|
sent reminder to ggailey777 |
|
Sent Teams message to @ggailey777 |
|
#sign-off thanks! |
|
@rellis-of-rhindleton : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
do-not-merge
and removed
ready-to-merge
qualifies-for-auto-merge
labels
|
I've resolved the conflict and will merge shortly. |
|
Learn Build status updates of commit df9ae8b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 1123890: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Calling out how category names are chosen to contrast with other frameworks. This was confusing to me and I thought a little more explicitness might help.
Also updated the first example for host.json settings to reflect Issue 1182.