Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in Azure Functions running in an Isolated Worker process #125041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

springcomp
Copy link

This PR adds a warning about log category names with a . character when running on Linux App Service plans.

There, logs with a category name that contains a . (period) character cannot be easily overridden using environment variable.
Although this is somewhat documented in the Logging in C# document, I think it would be worthwhile to add a short mention of those limitations here.

Copy link
Contributor

@springcomp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 62246c7:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-functions/dotnet-isolated-process-guide.md ⚠️Warning Details

articles/azure-functions/dotnet-isolated-process-guide.md

  • Line 814, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=bash#set-log-level-by-command-line-environment-variables-and-other-configuration' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 814, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=bash#set-log-level-by-command-line-environment-variables-and-other-configuration' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@v-dirichards
Copy link
Contributor

@ggailey777

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 3, 2024
Copy link
Contributor

Learn Build status updates of commit ea3c0ec:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/dotnet-isolated-process-guide.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@springcomp
Copy link
Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @ggailey777

Added a warning about log category names with a `.` character.
Fixed locale-specific link ; use absolute link to /dotnet instead.
Copy link
Contributor

Learn Build status updates of commit dfeff3b:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/dotnet-isolated-process-guide.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-ccolin
Copy link
Contributor

I sent an email to the content owner on 01/12/2025.

@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants