Appdata related patches #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the appstream project no longer supports `translatable=no` properties, and gettext extract them as translatable. I opened an issue to inform about the situation, but `translatable=no` properties are not accepted by developers. You can find the issue here: `https://github.com/ximion/appstream/issues/623` **Please test your script or string extraction process before merging this PR.** > In MetaInfo files, each individual paragraph of a description > (or enumerated entry) is translated individually, however, > you can only exclude the complete block from being translated > by adding `translate="no"` to the description element. Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
Flathub requires a developer tag and developer ID. Also Appstream decided to use rdns structure for developer ID. It allows reverse-dns IDs like sh.cozy, de.geigi or Fediverse handle (like @user@example.org) > A developer tag with a name child tag must be present. > Only one developer tag is allowed and the name tag also must be present only once in untranslated form. ``` <developer id="tld.vendor"> <name>Developer name</name> </developer> ``` Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name > The element should have a id property, containing a unique ID to identify the component developer / development team. It is recommended to use a reverse-DNS name, like org.gnome or io.github.ximion, or a Fediverse handle (like @user@example.org) as ID to achieve a higher chance of uniqueness. Source: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
|
Thanks @yakushabb ! At first I thought it wasn't possible to tag blocks as "not translatable", I was surprised as it is a nice feature (especially for small apps like Diffuse that don't have an army of translators to translate each and every release). But it's just a renaming, so it's a-ok! Also ok for the dev ID (I actually don't really know what to put here). And how about removing |
|
If you remove the 'developer_name' tag, LTS releases cannot display the developer name.
|
|
Gotcha! Thanks 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appdata: translate=no properties
It appears that the appstream project no longer supports
translatable=noproperties, and gettext extract them as translatable.I opened an issue to inform about the situation, but
translatable=noproperties are not accepted by developers. You can find the issue
here: `ximion/appstream#623
Please test your script or string extraction process before merging this PR.
Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
appdata: Add developer ID
Flathub requires a developer tag and developer ID. Also Appstream decided to use rdns structure for developer ID.
It allows reverse-dns IDs like sh.cozy, de.geigi or Fediverse handle (like @[email protected])
Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name
Source: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer