Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local bounds #26

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix local bounds #26

merged 1 commit into from
Oct 18, 2021

Conversation

JonathSpirit
Copy link
Contributor

In my original pr #21 I forget about the BASE_RADIUS for the local bounds.

This fix the light rectangle, and possible glitch with small light.

MiguelMJ
MiguelMJ approved these changes Oct 18, 2021
View reviewed changes
Copy link
Owner

@MiguelMJ MiguelMJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've gotten the grasp of RadialLight! This is an important fix. Thank you :D

@MiguelMJ MiguelMJ merged commit f05d2db into MiguelMJ:dev Oct 18, 2021
@JonathSpirit JonathSpirit deleted the localBoundsDev branch October 18, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelMJ MiguelMJ MiguelMJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathSpirit @MiguelMJ