Fix bug when mergeRequestsToDisplay is not set yet (#110)

Mikescops · Jun 15, 2024 · 3fa353b · 3fa353b
1 parent 2520d70
commit 3fa353b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/popup/components/Content.tsx b/src/popup/components/Content.tsx
@@ -67,7 +67,7 @@ export const Content = (props: Props) => {
     let mergeRequestsToDisplay = mrToDisplayByTabId[currentTab] ?? mrData.mrReceived;
 
     if (currentTab === 'to_review' && !draftInToReviewTab) {
-        mergeRequestsToDisplay = mergeRequestsToDisplay.filter((mr) => !mr.work_in_progress);
+        mergeRequestsToDisplay = mergeRequestsToDisplay?.filter((mr) => !mr.work_in_progress);
     }
 
     return <MergeRequests mergeRequests={mergeRequestsToDisplay} />;

diff --git a/src/popup/components/MergeRequestItem.tsx b/src/popup/components/MergeRequestItem.tsx
@@ -36,7 +36,7 @@ export const MergeRequestItem = ({ mr }: Props) => {
                 approved:
                     mr.approvals &&
                     mr.approvals.approved_by &&
-                    mr.approvals.approved_by.filter((approval) => {
+                    mr.approvals.approved_by?.filter((approval) => {
                         return approval.user.id === assignee.id;
                     }).length > 0
             } as UserWithApproval;