Skip to content

Commit

Permalink
Improve avatars spacing (#118)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mikescops authored Jun 18, 2024
1 parent 529371f commit c8bfe08
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/popup/components/AvatarWithTooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ export const AvatarWithTooltip = (props: Props) => {
);

return (
<Tooltip className={'userAvatar'} aria-label={assignee.name} direction={props.direction ?? 'w'}>
<Tooltip aria-label={assignee.name} direction={props.direction ?? 'w'}>
{assignee.approved ? approvedMark : null}
<Avatar src={assignee.avatar_url} alt={assignee.name} square size={props.size ?? 40} sx={{ mr: 1 }} />
<Avatar src={assignee.avatar_url} alt={assignee.name} square size={props.size ?? 40} />
</Tooltip>
);
};
2 changes: 1 addition & 1 deletion src/popup/components/IssueItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const IssueItem = ({ issue }: Props) => {
</Label>
</Box>
</Box>
<Box className={'avatarsList'}>
<Box display={'flex'} className={'avatarsList'}>
{avatars}{' '}
{assignees.length > 3 ? (
<Tooltip
Expand Down
2 changes: 1 addition & 1 deletion src/popup/components/MergeRequestItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const MergeRequestItem = ({ mr }: Props) => {
</Label>
</Box>
</Box>
<Box className={'avatarsList'}>
<Box display={'flex'} className={'avatarsList'}>
{avatarsUI}{' '}
{reviewers.length > 3 ? (
<Tooltip
Expand Down
2 changes: 1 addition & 1 deletion src/popup/components/TodoItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const TodoItem = (props: Props) => {
</Label>
</div>
</Box>
<Box>
<Box display={'flex'} sx={{ alignItems: 'center' }}>
<Tooltip aria-label={'Mark as done'} direction="w">
<Button variant="default" size="small" className={'mt-1'} onClick={setTodoAsDone}>
<CheckIcon />
Expand Down
12 changes: 4 additions & 8 deletions src/popup/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,8 @@ body {
.avatarsList {
max-width: 200px;
text-align: end;
}

.userAvatar {
position: relative;
display: inline-block;
align-items: center;
column-gap: 4px;
}

.inline-avatar {
Expand All @@ -118,7 +115,7 @@ body {

.statusMark {
position: absolute;
right: 2px;
right: -2px;
top: 25px;
width: 20px;
height: 20px;
Expand All @@ -135,8 +132,7 @@ body {
vertical-align: middle;
text-align: center;
border-radius: 3px;
padding: 12px 6px;
margin-left: -4px;
padding: 10px 6px;
}

.moreAssigneesIcon:hover {
Expand Down

0 comments on commit c8bfe08

Please sign in to comment.