Merge pull request #8 from Mikescops/bugfix/prevent-crash-unknown-errors

Prevent crash on unknown errors
Mikescops · Dec 28, 2023 · bfccbed · bfccbed
2 parents 1aed6ab + 0625843
commit bfccbed
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/deviceClient.ts b/src/deviceClient.ts
@@ -162,10 +162,13 @@ export class UpnpDeviceClient extends EventEmitter {
         const responseDoc = et.parse(response.body.toString());
 
         if (response.statusCode !== 200) {
-            const errorCode = parseInt(responseDoc.findtext('.//errorCode').toString());
-            const errorDescription = responseDoc.findtext('.//errorDescription').toString().trim();
+            const errorCode = responseDoc.findtext('.//errorCode').toString() ?? '0';
+            const errorDescription = responseDoc.findtext('.//errorDescription').toString().trim() ?? 'Unknown error';
 
-            throw new UpnpError('EUPNP', errorDescription, { errorCode, httpCode: response.statusCode });
+            throw new UpnpError('EUPNP', errorDescription, {
+                errorCode: parseInt(errorCode),
+                httpCode: response.statusCode
+            });
         }
 
         // Extract response outputs
@@ -177,7 +180,7 @@ export class UpnpDeviceClient extends EventEmitter {
 
         const result = {};
         outputs.forEach((name) => {
-            result[name] = responseDoc.findtext('.//' + name).toString();
+            result[name] = responseDoc.findtext('.//' + name).toString() ?? '';
         });
 
         return result;