ALFMOB-61: Refactor PDP screen's details to use a ScrollView #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoPinhoMinder
force-pushed
the
techdebt/ALFMOB-61-refactor-pdp-screen-details-to-use-scroll-view
branch
10 times, most recently
from
0bb6b4a to
7a9e2a5
Compare
JoaoPinhoMinder
force-pushed
the
techdebt/ALFMOB-61-refactor-pdp-screen-details-to-use-scroll-view
branch
3 times, most recently
from
586c5a6 to
109f0b3
Compare
Converted sheet that shows product details to a draggable view that mimics the same behaviour, since the bottom sheet was causing some navigation bugs.
JoaoPinhoMinder
force-pushed
the
techdebt/ALFMOB-61-refactor-pdp-screen-details-to-use-scroll-view
branch
from
109f0b3 to
4718fe0
Compare
| @@ -108,6 +105,7 @@ struct ProductDetailsView<ViewModel: ProductDetailsViewModelProtocol>: View { | |||
| } | |||
|
|
|||
| @ViewBuilder private var pdpView: some View { | |||
| // TODO: Check why iPad uses a different view | |||
There was a problem hiding this comment.
Hey 👋 @p4checo asked me to take a look and help.
The reason why we had a different view for iPad and iPhone pre iOS 16.4 is:
- iPhone only supports sheets with detents starting on iOS 16.4
- iPad does support them but sheets in general on iPad are nothing like the ones on iPhone and so we just decided to not to use it and keep it as a simple ScrollView. But there were no other blockers or particular reasons :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://mindera.atlassian.net/browse/ALFMOB-61
Description
Converted sheet that shows product details to a draggable view that mimics the same behaviour, since the bottom sheet was causing some navigation bugs.