Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: low-speed-spidev will not load if MinnowBoard is not detected. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whbruce
Copy link

@whbruce whbruce commented Nov 11, 2016

Signed-off-by: Henry Bruce [email protected]

@dvhart
Copy link
Collaborator

dvhart commented Nov 11, 2016

John, can you cover?

Darren Hart
Intel Open Source Technology Center

On 11/11/16, 10:25 AM, "Henry Bruce" <[email protected]mailto:[email protected]> wrote:

Signed-off-by: Henry Bruce [email protected]:[email protected]


You can view, comment on, or merge this pull request online at:

#17

Commit Summary
· modules: low-speed-spidev will not load if MinnowBoard is not detected.
File Changes
· M modules/low-speed-spidev/low-speed-spidev.chttps://github.com//pull/17/files#diff-0 (10)
Patch Links:
· https://github.com/MinnowBoard/minnow-max-extras/pull/17.patch
· https://github.com/MinnowBoard/minnow-max-extras/pull/17.diff


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/17, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AACNnSGi9KSGZyISuPcH2p0dUURkofKpks5q9LMAgaJpZM4KwAk_.

@dvhart
Copy link
Collaborator

dvhart commented Nov 11, 2016

Yeah, let me take a look

On 11/11/2016 12:26 PM, Hart, Darren wrote:

John, can you cover?

Darren Hart

Intel Open Source Technology Center

On 11/11/16, 10:25 AM, "Henry Bruce" <[email protected]
mailto:[email protected]> wrote:

Signed-off-by: Henry Bruce [email protected]
mailto:[email protected]


    You can view, comment on, or merge this pull request online at:

#17

    Commit Summary

· modules: low-speed-spidev will not load if MinnowBoard is not
detected.

    File Changes

· M modules/low-speed-spidev/low-speed-spidev.c
https://github.com/MinnowBoard/minnow-max-extras/pull/17/files#diff-0
(10)

    Patch Links:

· https://github.com/MinnowBoard/minnow-max-extras/pull/17.patch

· https://github.com/MinnowBoard/minnow-max-extras/pull/17.diff


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#17, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AACNnSGi9KSGZyISuPcH2p0dUURkofKpks5q9LMAgaJpZM4KwAk_.

@warthog9
Copy link
Collaborator

So there's a merge conflict (I might have just incurred that actually, sorry)

Is there a specific impetus to making this as MinnowBoard specific as you are suggesting?

@whbruce
Copy link
Author

whbruce commented Nov 11, 2016

No rush. On review, this is only useful if future MinnowBoards use the same spidev module. So feel free to close without merging. Your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants