Fix up outstanding issues with e2e tests #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squizzi
added
the
test e2e
|
Looks like hosted tests are broken, if I can get #536 squared away I can try to get those green. |
squizzi
force-pushed
the
e2e-green-please
branch
from
9de66bb to
a1b94df
Compare
Signed-off-by: Kyle Squizzato <[email protected]>
squizzi
force-pushed
the
e2e-green-please
branch
from
a1b94df to
f6659b5
Compare
Signed-off-by: Kyle Squizzato <[email protected]>
|
Closing in favor of a new PR based on a repo branch, see #575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #360 has been merged the tests are actually running the right way (yay 🎉) and I can open a fork and they will run (another yay 🎉), but there may be some outstanding issues with the tests we need to resolve. This PR will serve to iterate over the e2e tests and get them green running in their native environment so that we can collectively say Y-A-Y.