Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample of permissions/Fix permissions of existing jobs #162

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

m-tmatma
Copy link
Contributor

Add sample of permissions

@m-tmatma
Copy link
Contributor Author

@MishaKav
The existing jobs failed, so added/fixed permissions.

@m-tmatma m-tmatma changed the title Add sample of permissions Add sample of permissions/Fix permissions of existing jobs Apr 13, 2024
@m-tmatma
Copy link
Contributor Author

@MishaKav
In my actions job, the original permission was OK,
But this PR failed.

So I tried to add checks: write.

I used the setting at https://github.com/EnricoMi/publish-unit-test-result-action

@m-tmatma
Copy link
Contributor Author

@MishaKav
Do you choose Read and write permissions in General of Actions of the repository?

image

@MishaKav
Copy link
Owner

yes, there are the things that I have

image

@m-tmatma
Copy link
Contributor Author

@MishaKav
m-tmatma#4 is PR from my fork to my fork.

https://github.com/m-tmatma/pytest-coverage-comment/actions/runs/8676446011/job/23790962655?pr=4 failed, but it failed at Create the Badge which tries to change your gist.
So it is expected to fail in my account.

Please push the branch of this PR to your reposotory, create a PR and check if the PR succeeds.

@MishaKav MishaKav merged commit 0f5f92e into MishaKav:main Apr 14, 2024
1 check failed
@m-tmatma
Copy link
Contributor Author

thank you for merging

@m-tmatma m-tmatma deleted the feature/fix-README branch April 14, 2024 06:23
@MishaKav
Copy link
Owner

thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants