Skip to content

Commit

Permalink
fix: Fixed some issues w/ metadata parsing
Browse files Browse the repository at this point in the history
- Render message on "Save Errors" screen if we have no errors
  • Loading branch information
cyanChill committed Sep 8, 2024
1 parent ddfe02d commit 8574a9d
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 13 deletions.
2 changes: 1 addition & 1 deletion mobile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@expo/vector-icons": "^14.0.2",
"@gorhom/bottom-sheet": "5.0.0-alpha.11",
"@miblanchard/react-native-slider": "^2.6.0",
"@missingcore/react-native-metadata-retriever": "^0.3.0",
"@missingcore/react-native-metadata-retriever": "^0.4.0",
"@paralleldrive/cuid2": "^2.2.2",
"@react-native-async-storage/async-storage": "1.24.0",
"@react-navigation/native": "^6.1.18",
Expand Down
34 changes: 23 additions & 11 deletions mobile/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions mobile/src/app/setting/insights/save-errors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Text, View } from "react-native";
import { db } from "@/db";

import { AnimatedHeader } from "@/components/navigation/animated-header";
import { Description } from "@/components/ui/text";

/** Screen for `/setting/insights/save-errors` route. */
export default function SaveErrorsScreen() {
Expand All @@ -30,6 +31,11 @@ export default function SaveErrorsScreen() {
</>
)}
showsVerticalScrollIndicator={false}
ListEmptyComponent={
<Description className="mb-2 text-start text-sm">
No save errors found.
</Description>
}
/>
</AnimatedHeader>
);
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/resources/licenses.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"@missingcore/react-native-metadata-retriever": {
"name": "@missingcore/react-native-metadata-retriever",
"version": "0.3.0",
"version": "0.4.0",
"copyright": "Copyright (c) 2024 MissingCore <[email protected]>",
"source": "https://github.com/MissingCore/react-native-metadata-retriever",
"license": "MIT",
Expand Down

0 comments on commit 8574a9d

Please sign in to comment.