Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acceptance tests #39

Merged
merged 8 commits into from
Feb 26, 2019
Merged

Update acceptance tests #39

merged 8 commits into from
Feb 26, 2019

Conversation

shoekstra
Copy link
Member

@shoekstra shoekstra commented Feb 25, 2019 •
edited
Loading

What's happening in this PR:

  • Removed the cosmic_egress_firewall and cosmic_firewall resources (closes Remove egress firewall and firewall resource #36)
  • Removed any references to existing resources, except to use an existing VPC, cause building VPCs is slow; any other resources are built as required and destroyed afterward
  • Removed any tests using isolated networks; Cosmic now only supports VPC networks and Private networks.
  • Removed a bunch of variables required to do testing; have hardcoded as much as possible into the test data but somethings could not be avoided, like COSMIC_VPC_ID or COSMIC_SERVICE_OFFERING_1
  • Reformatted the test data, easier to read now
  • While making tests pass also fixed cosmic_loadbalancer_rule so that it does not recreate the resource with every change
  • All tests now pass 🎉

Will add tests for resource importers in a separate PR; this one just makes existing tests relevant and passing.

@shoekstra
Fix file permissions
6fa074d 
Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Add GNUmakefile and support scripts
7dc71d9 
Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Remove empty main_test.go
ca57aa4 
Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Remove cosmic_egress_firewall and cosmic_firewall
74c918d 
These two resources are no longer supported by the Cosmic API and will
be removed in a future release of Cosmic, going removing them from this
provider now.

Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Fix formatting in test plans
92c8a7a 
Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Update test suite
57b98e3 
* Build and tear down dependencies instead of relying on resources to
exist (except VPCs, those are time consuming to build)
* Update tests so they pass
* Clean up testing variables; use more hard coded values and depend on
less being provided by tester

Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Don't recreate loadbalancer_rule resources
f13f048 
No longer need to recreate the resource when changing the member_ids,
private_port, public_port or protocol options.

Signed-off-by: Stephen Hoekstra <[email protected]>
@shoekstra
Increase acceptance test timeout
7e56909 
Signed-off-by: Stephen Hoekstra <[email protected]>
@ddegoede ddegoede merged commit 0ebedf6 into master Feb 26, 2019
@shoekstra shoekstra deleted the update_acc_tests branch February 26, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddegoede ddegoede ddegoede approved these changes

@sanderv32 sanderv32 Awaiting requested review from sanderv32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove egress firewall and firewall resource
2 participants
@shoekstra @ddegoede