Show an alert dialog with the start message if it contains errors or warnings #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchBradley
reviewed
May 5, 2024
|
Maybe what I am seeing is merge order artifacts. If I just look at the last commit it all makes sense. What I want to avoid is inadvertently undoing older stuff. We got bitten by that some time ago and I don't want that to happen again. |
|
I was confused by the two branches: revamp vs Revamp and used the later instead of the further ... I fixed it now. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the request on Discord I added a check on errors and warnings in the start message. If there are errors or warnings then an alert dialog is shown on startup.
Not sure if this is the best possible implementation. I am not quite happy but could not find a better way to get the start message.