Don't try to start a coroutine in VirtualizedScrollRectList when the GameObject is inactive #972
+130
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update VirtualizedScrollRectList.cs
Update VirtualizedScrollRectList.cs
keveleigh
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
keveleigh
force-pushed
the
virtualizedscrollrectlist
branch
2 times, most recently
from
9034ae9 to
6be76b6
Compare
keveleigh
force-pushed
the
virtualizedscrollrectlist
branch
2 times, most recently
from
e608656 to
a38ebd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828
Delays creating the coroutine until the next time the script/GameObject is enabled. Adds a test to ensure this case is accounted for.
Before:
After:
