-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ScaleMaintainType #976
Open
nayanatharap
wants to merge
11
commits into
MixedRealityToolkit:main
Choose a base branch
from
nayanatharap:user/npalanivel/BoundsHandleScaleMaintainTypes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introduce ScaleMaintainType #976
nayanatharap
wants to merge
11
commits into
MixedRealityToolkit:main
from
nayanatharap:user/npalanivel/BoundsHandleScaleMaintainTypes
+237
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce different options for scaling bounds handles. The options include: - Maintaining global size (previously stored as a separate bool property) - Setting scale based on initial parent scale - Adjusting scale to retain same size
bd3abcf
to
eb48694
Compare
…olkit-Unity into user/npalanivel/BoundsHandleScaleMaintainTypes
…s://github.com/nayanatharap/MixedRealityToolkit-Unity into user/npalanivel/BoundsHandleScaleMaintainTypes
471b186
to
1f360c6
Compare
keveleigh
reviewed
Feb 12, 2025
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
keveleigh
reviewed
Feb 14, 2025
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979 - Introduce different options for scaling bounds handles. The options include:
GlobalSize - Maintains global size (previously stored as a separate bool property):
![GlobalSize](https://private-user-images.githubusercontent.com/39957281/408763148-3ab6f1af-657e-46ad-b3cd-b724b724c77b.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzI1MjQsIm5iZiI6MTczOTkzMjIyNCwicGF0aCI6Ii8zOTk1NzI4MS80MDg3NjMxNDgtM2FiNmYxYWYtNjU3ZS00NmFkLWIzY2QtYjcyNGI3MjRjNzdiLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyMzAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3ZGIwYWU0YTdhOWU0NjgxZDE2YzBlODNkM2NiYzM4ZmZjZjYxNjZlMmQyNDNkNWI4Yzc5ZWMyMmY5YzkyNWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qOb-OpkFW0tiQrnxKH0PprqIMpehCyqb0sgQfdWr-qo)
FixedScale - Sets scale based on initial parent scale:
![FixedScale](https://private-user-images.githubusercontent.com/39957281/408763147-fe6f881e-a7e7-493e-970d-72172a8b4997.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzI1MjQsIm5iZiI6MTczOTkzMjIyNCwicGF0aCI6Ii8zOTk1NzI4MS80MDg3NjMxNDctZmU2Zjg4MWUtYTdlNy00OTNlLTk3MGQtNzIxNzJhOGI0OTk3LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyMzAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjMTNmZDgxZWM2MGFmNmJkMzYyZjg3NzQ1NjI3YTRkMTFlODI5ZmRkMDA1YmRjMWU2ZmM0OTljZTdkYzgxNDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-UGeKC2qZcDjBcXqHauPdD-F_ErTrd8fSv_VAQBl2Vg)
Advanced - Adjusts scale to retain same size
![Advanced](https://private-user-images.githubusercontent.com/39957281/408763152-18d0a536-aa4e-4c99-8cb2-fa4a1e9847d8.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzI1MjQsIm5iZiI6MTczOTkzMjIyNCwicGF0aCI6Ii8zOTk1NzI4MS80MDg3NjMxNTItMThkMGE1MzYtYWE0ZS00Yzk5LThjYjItZmE0YTFlOTg0N2Q4LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyMzAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlMDI1OTlmNTZjMDhiNTJmMjI2Nzc2M2IwOWNmMGUyYTQwYmJjNzY4M2FmNDYzMGVkYTk0MmE1NDEyMmM4MTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2-FVGe7J9B3Kb3ypQgG6gbL0aWYhHReY5IoM2X8bxIQ)