Added: PageLoading now use "Loading..." has a title

MoOx · Jun 10, 2016 · c3b7ed8 · c3b7ed8
1 parent d9b58e5
commit c3b7ed8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## HEAD
+
+### Boilerplate
+
+- Added: ``PageLoading`` now use "Loading..." has a title
+  (@MoOx)
+
 # 0.13.0 - 2016-06-07
 
 ## tl;dr;

diff --git a/__tests__/index.js b/__tests__/index.js
@@ -80,6 +80,7 @@ test("should have html files", (t) => {
   t.truthy(includes(
     "loading/index.html",
     [
+      ">Loading...",
       "window.__INITIAL_STATE__ = {\"pages\":{\"/loading/\"",
     ]
   ))

diff --git a/boilerplate/web_modules/layouts/PageLoading/index.js b/boilerplate/web_modules/layouts/PageLoading/index.js
@@ -1,4 +1,5 @@
 import React, { Component } from "react"
+import Helmet from "react-helmet"
 import TopBarProgressIndicator from "react-topbar-progress-indicator"
 
 import styles from "./index.css"
@@ -16,6 +17,9 @@ export default class PageLoading extends Component {
   render() {
     return (
       <div>
+        <Helmet
+          title={ "Loading..." }
+        />
         <TopBarProgressIndicator />
         <div className={ styles.loader }>
           <div className={ styles.spinner }></div>

diff --git a/docs/web_modules/layouts/PageLoading/index.js b/docs/web_modules/layouts/PageLoading/index.js
@@ -1,4 +1,5 @@
 import React, { Component } from "react"
+import Helmet from "react-helmet"
 import TopBarProgressIndicator from "react-topbar-progress-indicator"
 
 import Banner from "../../Banner"
@@ -18,6 +19,9 @@ export default class PageLoading extends Component {
   render() {
     return (
       <div>
+        <Helmet
+          title={ "Loading..." }
+        />
         <TopBarProgressIndicator />
         <Banner small>
           <h1>{ " " }</h1>