🐛 Fixed: Phenomic <Link> understand collection links without the …

…base path

One caveat is now you can’t use ``<Link>`` to point to a path before
the current project base path. This is probably and edge case, more
than the case we are fixing here.
We might revisit this issue when refactoring how collection is handled
and  rendered.

docs/content/docs/usage/scripting.md

@@ -57,7 +57,11 @@ Phenomic provides a Link component to cover this case.
 Current ``react-router`` ``Link`` implementation just crash if you use an
 external link. Phenomic ``Link`` component fix this for you.
 This is especially handy if you generate links from unknown data
-(eg: markdow front-matter value that can point to internal or external pages) .
+(eg: markdow front-matter value that can point to internal or external pages).
+
+⚠️ One caveat is you can’t use ``<Link>`` to point to a path **before
+the current project base path**. This is probably and edge case, more than using
+``<Link>`` for project related and collection links.
 
 #### ``BodyContainer``
 

src/components/Link/__tests__/index.js

@@ -67,27 +67,6 @@ test("should render normal <a> tag if to is not 'local'", () => {
   .toEqual("http://test.com")
 })
 
-test("should render normal <a> tag if to is not in the same root path", () => {
-  const component = renderer(
-    createElement(
-      Link,
-      {
-        to: "/root",
-        className: "foo",
-        children: <span />,
-      },
-    ),
-    {
-      router: {
-        isActive: () => false,
-      },
-    }
-  )
-
-  expect(component.props.href)
-  .toEqual("/root")
-})
-
 test("should allow passing props to <a> tag", () => {
   const component = renderer(
     createElement(

src/components/Link/index.js

@@ -42,8 +42,16 @@ function Link(
   link.href = to
 
   if (
-    origin(link) === origin(window.location) &&
-    link.pathname.indexOf(process.env.PHENOMIC_USER_PATHNAME) > -1
+    origin(link) === origin(window.location)
+    // we might want to restrict Link to path including the pathname
+    // but this will require to preprend pathname to all Links from the
+    // collection, which sucks.
+    // If people wants to use Link for a same domain, but in the parent path,
+    // you will need to includes the entire url, / won't work at it will use
+    // the react-router basename defined by Phenomic.
+    // &&
+    // link.pathname.includes(process.env.PHENOMIC_USER_PATHNAME)
+    // link.pathname.indexOf(process.env.PHENOMIC_USER_PATHNAME) > -1
   ) {
     return (
       <RouterLink

themes/phenomic-theme-base/src/components/Header/index.js

@@ -13,7 +13,7 @@ const Header = (props, { metadata: { pkg } }) => (
       <div className={ styles.navPart1 }>
         <Link
           className={ styles.link }
-          to={ "" }
+          to={ "/" }
         >
           { "Home" }
         </Link>