-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove react-native-mmkv dependency #208
base: 2.0
Are you sure you want to change the base?
Conversation
general question: do we need any sort of data migration? |
@bangtoven Yeah, this will lose data for folks that were not passing in a storage object into the provider. I think we have two options: |
@vishnumad gotcha. since we don't have that many client apps yet, i think we would just go with your second option instead of implementing+maintaining migration logic |
@vishnumad, thanks for working on this, are there plans on landing this PR? |
Review Error for Chico1244 @ 2023-08-04 06:20:55 UTC |
Review Error for Chico1244 @ 2023-08-04 06:45:00 UTC |
Review Error for Chico1244 @ 2023-08-04 06:45:33 UTC |
Review Error for Imebeez @ 2023-08-31 12:01:28 UTC |
Review Error for Imebeez @ 2023-09-14 01:09:34 UTC |
Summary
Replace react-native-mmkv with shared preferences on Android and user defaults on iOS which fixes #199
How did you test your changes?
Handshake
handshake.mp4
Request
make-request.mp4
Address caching
cached-address.mp4