Fix the link check for Github sites #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing in the correct config file for the link checker code github/docs#17358
Without the fix, we get the error
```
Traceback (most recent call last):
File "/srv/conda/envs/notebook/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3552, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "/tmp/ipykernel_59/3601587137.py", line 2, in <module>
import emeval.input.spec_details as eisd
File "<fstring>", line 1
(post_body=)
^
SyntaxError: invalid syntax
```
This works on my local environment with python 3.8.2
```
Set up the dependencies
import emeval.input.spec_details as eisd
import emeval.input.phone_view as eipv
import emeval.input.eval_view as eiev
import sys
sys.version
'3.8.2 (default, Mar 25 2020, 11:22:43) \n[Clang 4.0.1 (tags/RELEASE_401/final)]'
```
So forcing the environment to 3.8.2 so we don't have to go around and fix all the f-strings
Since version 16 is no longer supported
|
Current failure: Not sure how this will ever work unless we have the data files checked in, given that cardshark is also down... |
|
GitHub warns for greater than 50MB, fails for greater than 100MB. |
- Remove line related to `bin/data` from the gitignore - Check in all the data files pending coordination with NREL data storage folks
Check in the related data files Fix the evaluation view to take the time range for the ground truth retrieval into account Change the notebook to read from the spec and use the new eval view function
In the data exploration template as well Follow-on to e7c1749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing in the correct config file for the link checker code github/docs#17358