Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run test scripts #250

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix run test scripts #250

merged 3 commits into from
Sep 6, 2024

Conversation

flxst
Copy link
Member

@flxst flxst commented Sep 4, 2024

What does this PR do?

This PR is a follow-up to #241 and fixes a few minor things:

  • validity of 3rd input argument (--cov / --no-cov) in run_distributed_tests.sh is checked
  • run_distributed_tests.sh is called with --no-cov from tests/tests.py
  • unused 3rd input argument in run_all_tests.sh is removed

General Changes

  • none

Breaking Changes

  • none

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)
  • I have updated the internal changelog (CHANGELOG_DEV.md)

@flxst flxst self-assigned this Sep 4, 2024
@flxst flxst requested a review from le1nux September 4, 2024 09:44
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! LGTM :-)

@le1nux le1nux merged commit 4cbd9e7 into main Sep 6, 2024
1 check passed
@le1nux le1nux deleted the fix/run_tests branch September 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants