Make Hidden Dimension Configurable For SwiGLU #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a change to the SwiGLU activation by making the hidden dimension configurable. Previously, the hidden dimension was fixed (4 *
n_embd), limiting flexibility in customizing the model architecture especially when using group query attention. This update enhances the usability of SwiGLU by allowing users to specify a custom hidden dimension during initialization.General Changes
ffn_hiddento the SwiGLU module.Breaking Changes
Checklist before submitting final PR
python tests/tests.py)CHANGELOG_DEV.md)