Fix Process.Start

.gitmodules

@@ -1,3 +1,6 @@
 [submodule "dependencies/quick-library"]
 	path = dependencies/quick-library
 	url = https://github.com/ModuleArt/quick-library
+[submodule "dependencies/qpv-plugins"]
+	path = dependencies/qpv-plugins
+	url = https://github.com/ModuleArt/qpv-plugins

quick-picture-viewer/App.config

@@ -5,9 +5,6 @@
             <section name="quick_picture_viewer.Properties.Settings" type="System.Configuration.ClientSettingsSection, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" allowExeDefinition="MachineToLocalUser" requirePermission="false"/>
         </sectionGroup>
     </configSections>
-    <System.Windows.Forms.ApplicationConfigurationSection>
-        <add key="DpiAwareness" value="PerMonitorV2"/>
-    </System.Windows.Forms.ApplicationConfigurationSection>
     <startup> 
         <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/>
     </startup>

quick-picture-viewer/Properties/AssemblyInfo.cs

@@ -0,0 +1,37 @@
+using System.Resources;
+using System.Reflection;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Quick Picture Viewer")]
+[assembly: AssemblyDescription("Lightweight, versatile desktop image viewer for Windows. The best replacement for the default Windows photo viewer.")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("Module Art")]
+[assembly: AssemblyProduct("Quick Picture Viewer")]
+[assembly: AssemblyCopyright("Copyright © 2023 Module Art")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]
+
+// The following GUID is for the ID of the typelib if this project is exposed to COM
+[assembly: Guid("53748c49-255e-424b-b789-5919cefef473")]
+
+// Version information for an assembly consists of the following four values:
+//
+//      Major Version
+//      Minor Version
+//      Build Number
+//      Revision
+//
+// You can specify all the values or you can default the Build and Revision Numbers
+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("3.1.5")]
+[assembly: AssemblyFileVersion("3.1.5")]
+[assembly: NeutralResourcesLanguage("en")]

quick-picture-viewer/forms/AboutForm.cs

@@ -53,7 +53,11 @@ private void InitLanguage()
 
 		private void makeDefaultBtn_Click(object sender, EventArgs e)
 		{
-			Process.Start("ms-settings:defaultapps");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "ms-settings:defaultapps"
+			});
 		}
 
 		private void updatesBtn_Click(object sender, EventArgs e)
@@ -64,12 +68,20 @@ private void updatesBtn_Click(object sender, EventArgs e)
 
 		private void button1_Click(object sender, EventArgs e)
 		{
-			Process.Start("https://github.com/ModuleArt/quick-picture-viewer/");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "https://github.com/ModuleArt/quick-picture-viewer/"
+			});
 		}
 
 		private void developerBtn_Click(object sender, EventArgs e)
 		{
-			Process.Start("https://moduleart.github.io");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "https://moduleart.github.io"
+			});
 		}
 	}
 }

quick-picture-viewer/forms/AboutForm.resx

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
+  <!--
     Microsoft ResX Schema 
-    
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
     
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -123,16 +123,16 @@
   <assembly alias="System.Drawing" name="System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
   <data name="developerBtn.Image" type="System.Drawing.Bitmap, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
     <value>
-        iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8
-        YQUAAAAZdEVYdFNvZnR3YXJlAEFkb2JlIEltYWdlUmVhZHlxyWU8AAABt0lEQVQ4T2PAAxiBmAmKQWyi
-        AUgxMxBzq2XvjNEsOloh5VEjDeSzQOXwApBtnAqRs5y0ys4c16m+8h+EtSsvPlbP2ZULlOMBYpDhGAaB
-        NHLI+LUbaRYfWw3TiI6BBj1STloZAFTLBcQgg8AAZBqfVMiqVQpJe/9rFJ/BqhmEtcov/JcOW/FfyGnC
-        FV7jImugPpDFDCyiTm1hMpFb/8MwyCCQYmSNcrEb/ws5T/ovYN8HxnwW9f1AvWwgA1iFbWtikQ2AYaW0
-        g/8VErahaIQbYF49GaiXA68BMCziPgvTALPqKUC9nBgGiLn1bxVz6V4mHb7xC1zMZ9F/fqumi1wa0VMJ
-        GiDuNX0mUExNwDC1GG6Ax+Q1QDENLvWINIIGSPjOAUkICFtXJMDFfGZNBYlxayfEEWsAn7BtdRy6GLd2
-        YixWAwTNC31hiiX95k8EivFgMZQX6AVfuAHmtSB17CADQIlBVMS+sUDcY1IXt4qnOpDPicUAbpA6bt3U
-        Al7j4i42KUuQOlD+AAMQA5TOeYGYFYjZUA2YC4pzkHPR1eHMXCz8+gk2MhGbPoMMEHXpygCKgVMdKmBg
-        AABk2xwZ8Mq9nAAAAABJRU5ErkJggg==
+        iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABGdBTUEAALGPC/xhBQAAABl0RVh0U29m
+        dHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAG3SURBVDhPY8ADGIGYCYpBbKIBSDEzEHOrZe+M0Sw6
+        WiHlUSMN5LNA5fACkG2cCpGznLTKzhzXqb7yH4S1Ky8+Vs/ZlQuU4wFikOEYBoE0csj4tRtpFh9bDdOI
+        joEGPVJOWhkAVMsFxCCDwABkGp9UyKpVCkl7/2sUn8GqGYS1yi/8lw5b8V/IacIVXuMia6A+kMUMLKJO
+        bWEykVv/wzDIIJBiZI1ysRv/CzlP+i9g3wfGfBb1/UC9bCADWIVta2KRDYBhpbSD/xUStqFohBtgXj0Z
+        qJcDrwEwLOI+C9MAs+opQL2cGAaIufVvFXPpXiYdvvELXMxn0X9+q6aLXBrRUwkaIO41fSZQTE3AMLUY
+        boDH5DVAMQ0u9Yg0ggZI+M4BSQgIW1ckwMV8Zk0FiXFrJ8QRawCfsG11HLoYt3ZiLFYDBM0LfWGKJf3m
+        TwSK8WAxlBfoBV+4Aea1IHXsIANAiUFUxL6xQNxjUhe3iqc6kM+JxQBukDpu3dQCXuPiLjYpS5A6UP4A
+        AxADlM55gZgViNlQDZgLinOQc9HV4cxcLPz6CTYyEZs+gwwQdenKAIqBUx0qYGAAAGTbHBnwyr2cAAAA
+        AElFTkSuQmCC
 </value>
   </data>
   <data name="githubBtn.Image" type="System.Drawing.Bitmap, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">

quick-picture-viewer/forms/MainForm.cs

@@ -11,6 +11,7 @@
 using System.Linq;
 using System.Timers;
 using System.Windows.Forms;
+using static System.Net.Mime.MediaTypeNames;
 
 namespace quick_picture_viewer
 {
@@ -1383,7 +1384,12 @@ private void showOpenWithDialog(string path)
 		{
 			string args = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.System), "shell32.dll");
 			args += ",OpenAs_RunDLL " + path;
-			Process.Start("rundll32.exe", args);
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "rundll32.exe",
+				Arguments = args
+			});
 		}
 
 		private void externalButton_Click(object sender, EventArgs e)
@@ -1744,7 +1750,11 @@ public void RestartApp()
 
 		public void NewWindow()
 		{
-			Process.Start(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "quick-picture-viewer.exe"));
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "quick-picture-viewer.exe")
+			});
 		}
 
 		private void rotate180Button_Click(object sender, EventArgs e)
@@ -1823,7 +1833,12 @@ private void externalRunBtn_Click(object sender, EventArgs e)
 			{
 				string ext = "bmp";
 				if (currentFile != null) ext = Path.GetExtension(currentFile).Substring(1, Path.GetExtension(currentFile).Length - 1);
-				Process.Start(FileAssociation.GetExecFileAssociatedToExtension(ext), '"' + Path.Combine(currentFolder, currentFile) + '"');
+				Process.Start(new ProcessStartInfo
+				{
+					UseShellExecute = true,
+					FileName = FileAssociation.GetExecFileAssociatedToExtension(ext),
+					Arguments = '"' + Path.Combine(currentFolder, currentFile) + '"'
+				});
 			}
 			catch
 			{
@@ -1835,7 +1850,12 @@ private void externalFavoriteBtn_Click(object sender, EventArgs e)
 		{
 			try
 			{
-				Process.Start(Properties.Settings.Default.FavoriteExternalApp, '"' + Path.Combine(currentFolder, currentFile) + '"');
+				Process.Start(new ProcessStartInfo
+				{
+					UseShellExecute = true,
+					FileName = Properties.Settings.Default.FavoriteExternalApp,
+					Arguments = '"' + Path.Combine(currentFolder, currentFile) + '"'
+				});
 			}
 			catch
 			{
@@ -2411,7 +2431,12 @@ private void directoryLabel_Click(object sender, EventArgs e)
 			if (File.Exists(path))
 			{
 				string argument = "/select, \"" + path + "\"";
-				Process.Start("explorer.exe", argument);
+				Process.Start(new ProcessStartInfo
+				{
+					UseShellExecute = true,
+					FileName = "explorer.exe",
+					Arguments = argument
+				});
 			}
 			else
 			{

quick-picture-viewer/forms/PluginManForm.cs

@@ -167,12 +167,20 @@ private void deletePlugin(int numberInList)
 
 		private void morePluginsBtn_Click(object sender, EventArgs e)
 		{
-			Process.Start("https://github.com/ModuleArt/qpv-plugins");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "https://github.com/ModuleArt/qpv-plugins"
+			});
 		}
 
 		private void pluginWebsiteBtn_Click(object sender, EventArgs e)
 		{
-			if (listView1.SelectedIndices != null && listView1.SelectedIndices.Count > 0) Process.Start(pluginsLinks[listView1.SelectedIndices[0]]);
+			if (listView1.SelectedIndices != null && listView1.SelectedIndices.Count > 0) Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = pluginsLinks[listView1.SelectedIndices[0]]
+			});
 		}
 
 		private void AutoSizeColumns()

quick-picture-viewer/forms/SettingsForm.cs

@@ -3,6 +3,7 @@
 using System;
 using System.Diagnostics;
 using System.Drawing;
+using System.Security.Policy;
 using System.Windows.Forms;
 
 namespace quick_picture_viewer
@@ -311,7 +312,11 @@ private void langComboBox_SelectedIndexChanged(object sender, EventArgs e)
 
 		private void Ll_Click(object sender, EventArgs e)
 		{
-			Process.Start("https://github.com/" + (sender as LinkLabel).Text);
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "https://github.com/" + (sender as LinkLabel).Text
+			});
 		}
 
 		private void SettingsForm_Load(object sender, EventArgs e)
@@ -475,8 +480,13 @@ private bool GetBrowseFolderWithState()
 			{
 				const string browseWithKey1 = "HKEY_CLASSES_ROOT\\Directory\\Background\\shell\\QuickPictureViewer";
 				const string browseWithKey2 = "HKEY_CLASSES_ROOT\\Directory\\shell\\QuickPictureViewer";
-				string browseWithValue1 = (string)Registry.GetValue(browseWithKey1, string.Empty, string.Empty);
-				string browseWithValue2 = (string)Registry.GetValue(browseWithKey2, string.Empty, string.Empty);
+
+				string key1 = Registry.GetValue(browseWithKey1, string.Empty, string.Empty)?.ToString();
+				string key2 = Registry.GetValue(browseWithKey2, string.Empty, string.Empty)?.ToString();
+
+				string browseWithValue1 = !String.IsNullOrEmpty(key1) ? key1.ToString() : "";
+				string browseWithValue2 = !String.IsNullOrEmpty(key2) ? key2.ToString() : "";
+
 				if (browseWithValue1.Length > 0 && browseWithValue2.Length > 0) return true;
 				return false;
 			}
@@ -488,12 +498,20 @@ private bool GetBrowseFolderWithState()
 
 		private void makeDefaultBtn_Click(object sender, EventArgs e)
 		{
-			Process.Start("ms-settings:defaultapps");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "ms-settings:defaultapps"
+			});
 		}
 
 		private void helpTranslateBtn_Click(object sender, EventArgs e)
 		{
-			Process.Start("https://github.com/ModuleArt/quick-picture-viewer/wiki/Help-us-translate-this-app");
+			Process.Start(new ProcessStartInfo
+			{
+				UseShellExecute = true,
+				FileName = "https://github.com/ModuleArt/quick-picture-viewer/wiki/Help-us-translate-this-app"
+			});
 		}
 	}
 }