Code Refactoring v0.0.1 #16
Conversation
| @@ -0,0 +1,5 @@ | |||
|
|
|||
| iStore.xcodeproj/project.xcworkspace/xcuserdata/mohamedsayed.xcuserdatad/UserInterfaceState.xcuserstate | |||
There was a problem hiding this comment.
why did you add this change?
There was a problem hiding this comment.
It caused Problems with Applying stashed or merging other branches into the branch.
| var body: some View { | ||
| TabView { | ||
| HomeView() | ||
| HomeView(id: user.id, homeAddress: user.address.address, homePostalCode: user.address.postalCode, homeCity: user.address.city, homeState: user.address.state, homeLatitude: user.address.coordinates.lat, homeLongitude: user.address.coordinates.lng, currentAddress: locationDataManager.address, currentPostalCode: locationDataManager.postalCode, currentCity: locationDataManager.city, currentState: locationDataManager.state, currentLatitude: locationDataManager.latitude, currentLongitude: locationDataManager.longitude, isCurrentLocation: locationDataManager.isCurrentLocation, isGuest: isGuest, getLocationPermission: locationDataManager.requestUserLocationPermission) |
There was a problem hiding this comment.
Is it better to create a custom object with all passing properties and pass it directly to the HomeView? just an idea!
There was a problem hiding this comment.
ok, I will try it and push the changes.
| authenticationViewModel.authenticateUser(userName: userName, password: password) { | ||
| navigationCoordinator.switchView = .contentView | ||
| authenticationViewModel.showProgress = false | ||
| authenticationViewModel.authenticateUser() { result in |
There was a problem hiding this comment.
Why do you call this method in the view?
There was a problem hiding this comment.
Because It is the action for the login button.
There was a problem hiding this comment.
Can't see the button here :)
There was a problem hiding this comment.
you need to look better.
| switch result { | ||
| case .success(let currentUser): | ||
| DispatchQueue.main.async { | ||
| authenticationViewModel.user = currentUser |
There was a problem hiding this comment.
Also here why do you assign the values here?
There was a problem hiding this comment.
Because It's the completion of the authencation Method.
There was a problem hiding this comment.
There is something wrong here. This logic should be handle by the model view.
There was a problem hiding this comment.
I have to do it here as it affects the UI and the navigationCoordinator is an EnvironmentObject so It's properties must be accessed from the view.
| @@ -11,7 +11,7 @@ import SwiftUI | |||
| struct iStoreApp: App { | |||
| var body: some Scene { | |||
| WindowGroup { | |||
| ViewManager(navigationCoordinator: NavigationCoordinator(), authenticationViewModel: AuthenticationViewModel(authenticationManager: AuthenticationManager(), user: AuthenticatedUser(id: Int(), username: String(),firstName: String(), lastName: String(), maidenName: String(), email: String(), phone: String(), image: URL(fileURLWithPath: String()), address: HomeAddress(address: String(), city: String(), postalCode: String(), coordinates: Coordinates(lat: Double(), lng: Double()), state: String()))), locationDataManager: LocationDataManager(address: String(), postalCode: String(), city: String(), state: String(), latitude: Double(), longitude: Double())) | |||
| ViewManager(navigationCoordinator: NavigationCoordinator(user: AuthenticatedUser(id: Int(), username: String(),firstName: String(), lastName: String(), maidenName: String(), email: String(), phone: String(), image: URL(fileURLWithPath: String()), address: HomeAddress(address: String(), city: String(), postalCode: String(), coordinates: Coordinates(lat: Double(), lng: Double()), state: String()))), authenticationViewModel: AuthenticationViewModel(authenticationManager: AuthenticationManager(), user: AuthenticatedUser(id: Int(), username: String(),firstName: String(), lastName: String(), maidenName: String(), email: String(), phone: String(), image: URL(fileURLWithPath: String()), address: HomeAddress(address: String(), city: String(), postalCode: String(), coordinates: Coordinates(lat: Double(), lng: Double()), state: String())), userName: "kminchelle", password: "0lelplR"), locationDataManager: LocationDataManager(address: String(), postalCode: String(), city: String(), state: String(), latitude: Double(), longitude: Double())) | |||
There was a problem hiding this comment.
What's ViewManager? and Why did you pass all these parameters?
There was a problem hiding this comment.
It's responsible for navigating from loginView to ContentView and passing the user after authentication, It takes all these params because It holds the NavigationCoordinator, the AuthenticationViewModel and the LocationManager. And each one of them has Its own Params that need to be passed.
Requesting Code Review.