fix(bug): looping and filter on undefined object (#205)

* fix: add fallback false * fix: add null check in subcategory
Monday-Morning · May 22, 2022 · c5dda85 · c5dda85
1 parent 354b258
commit c5dda85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/client/src/pages/[category]/[subCategory].jsx b/client/src/pages/[category]/[subCategory].jsx
@@ -149,7 +149,7 @@ export async function getStaticProps({
   const subCategoryDetails = ROUTES.SUB_CATEGORIES.OBJECT[
     categoryName?.toUpperCase()
   ]
-    .filter(({ asyncRoutePath }) => asyncRoutePath === './SubCategory')
+    ?.filter(({ asyncRoutePath }) => asyncRoutePath === './SubCategory')
     .filter(({ shortName }) => shortName === subCategory)[0];
 
   if (!subCategoryDetails) {
@@ -174,7 +174,7 @@ export async function getStaticProps({
   } = await GraphClient.query({
     query: countOfArticlesBySubCategory,
     variables: {
-      categoryNumber: subCategoryDetails.idNumber,
+      categoryNumber: subCategoryDetails?.idNumber,
     },
   });
 

diff --git a/client/src/pages/[category]/index.jsx b/client/src/pages/[category]/index.jsx
@@ -140,7 +140,7 @@ export async function getStaticPaths() {
     params: { category: shortName },
   }));
 
-  return { paths, fallback: true };
+  return { paths, fallback: false };
 }
 
 export default CategoryPage;