-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add firebase remote config #376
base: main
Are you sure you want to change the base?
Conversation
isLivePageVisible = getValue(remote, 'isLivePageVisible').asBoolean(); | ||
} | ||
} | ||
initRemoteConfig(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a good practice. Make this call as part of some init firebase script where authentication and everything is being initialized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A solution would be to run this in the FirebaseContext we have wrapped over the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rutajdash I think this method is better as in future we may required many more values from remote config, in that case context will looked up bit messy, this style is referred from their docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then find a way to keep context clean. You never define a function and then add the call right there below it. That is a very bar practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rutajdash where I should exactly call this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the remote config call. Rest is good to go.
@rutajdash where should we exactly call the remote config. |
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Linked Issues
Fixes
Description
Please describe your pull request.
❤️Thank you!
Post merge checklist