Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .read() of FileField to close the file #2102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix .read() of FileField to close the file #2102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,4 @@ that much better:
* Paulo Amaral (https://github.com/pauloAmaral)
* Gaurav Dadhania (https://github.com/GVRV)
* Yurii Andrieiev (https://github.com/yandrieiev)
* Tristan Brown (https://github.com/tristanbrown)
1 change: 1 addition & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Changelog

Development
===========
- Fix the `.read()` feature of FileField to properly close the file.
- (Fill this out as you fix issues and develop your features).

Changes in 0.18.1
Expand Down
2 changes: 2 additions & 0 deletions mongoengine/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,6 +1632,8 @@ def read(self, size=-1):
return gridout.read(size)
except Exception:
return ''
finally:
gridout.seek(0)

def delete(self):
# Delete file from GridFS, FileField still remains
Expand Down