Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for adding custom music #10337

Open
wants to merge 3 commits into
base: content
Choose a base branch
from

Conversation

dreamscached
Copy link
Member

There is a use case for external code to add songs to the music selector menu (example how it's currently done in a hacky way)

However, it's impossible to add music to the list in a non-hacky way, as __paginate is protected and name-mangled.

This PR addresses that and adds a simple method for adding a song to the list (optionally, with setting the corresponding PM for custom music)

@dreamscached dreamscached changed the title Feature/music add api Method for adding custom music Nov 28, 2024
@ThePotatoGuy ThePotatoGuy self-assigned this Nov 28, 2024
Copy link
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda want to refactor the music system to allow for a more advanced player.
Furthermore I think we should be more careful with what we expose as public API, we have to live with those things basically forever, which means we can't easily change our systems.

@dreamscached
Copy link
Member Author

If we happen to change the system, I still think we should have a way to externally add music to it; it doesn't feel right to put submod custom music to the player's music folder, instead it could be added from submod folder and played from there directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants