Background Changing Framework

[multimokia]

Introducing MASBackgrounds:

BG changing framework is now here with this, which introduces MASBackground objects

• These objects have a variety of parameters which handle the day/night image to use as the 'room', and optional parameters which are for how the 'room' should look while it's raining, snowing, or overcast. (See the init for a MASBackground object for details)
• They also have the parameters to either hide_masks (so we don't have weather at all) and hide_calendar, which will not display the calendar for the drawing of the spaceroom.
• Backgrounds are also unlockable which allows for future expansion.

Other changes:

• Weather objects now have a precip_type associated with them. This allows us to decide what room to use (def, rain, overcast, or snow)
• As a result of allowing potentially different weather to be a case, window masks had to be changed to full size, so any possible future rooms would be supported by our current weather system. (Thank you @Legendkiller21 for helping out in making these, along with @Velius94 and @Orcaramelo for the frost on the snow windows + the night/overcast/space clouds)
• There is also a selector for BGs, but as we do not have any other rooms to use, it's init is commented out. (Feel free to review it for now, but I'd probably save it until we get backgrounds to use it for.)
• Also added the new night bg

Testing:

• Please make sure everything looks good
• Ensure that spaceroom calls also work right (shouldn't be as bad as last time since not that much changed)
• Ensure that progressive weather adjusts the room correctly

[ThePotatoGuy]

python named args like these are resolved on init and don't change dynamically, so if the current bg changes these params wont update. Even if renpy actualyl does this dynamically, should just use None for dynamic cases so no one looks at this and tries to do the same in py.

So have these default to None, then after the with None, check those args for None values and set to defaults accordingly.

[ThePotatoGuy]

since you repeat this pattern of if statements, i would make a private function like:

def __handleBG(self, desired_bg, fallback_bg):
    if desired_bg:
        return desired_bg
    return fallback_bg

then you can use that here like:

self.image_rain_day = self.__handle_bg(image_rain_day, image_day)

[ThePotatoGuy]

seeing that this pattern is being used (if type == constant, return value), it would be a lot nicer to use a dict mapping the constant to its appropriate image. Probably could even combine the day and night elements together like:

img_map = {
    PRECIP_TYPE_RAIN: (day_image, night_image),
    ...
}

[ThePotatoGuy]

i guess you're trying for brevity here, but this does a useless list build. I think you should make this simpler i.e: like

unlocked_count = 0
for mbj_obj in mas_background.BACKGROUND_MAP.itervalues():
    unlocked_count += int(mbg_obj.unlocked)

if unlocked_count < 2:
    # etc

and since this is in a global store, then it would be actually better to make that for loop in a function in the mas_background store where it returns the unlocked count, then you can do like:

if mas_background.unlockedBG_count() < 2:
    # etc

[ThePotatoGuy]

waiting for #4582

[jmwall24]

Everything works, just the calendar glows a bit at night against the new night filter, so if that could darken when we go to night, that'd be great.