Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2B spack #9598

Merged
merged 5 commits into from
Oct 29, 2022
Merged

2B spack #9598

merged 5 commits into from
Oct 29, 2022

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented Sep 24, 2022

#9376

Key Changes

  • adds 2b spack - thumbs is already included
  • adds 2b o31 intro
  • adds "hide-ring" ex-prop

TODO

  • add o31 intro dialogue

Testing

  • verify looks good
  • verify ring is hidden when outfit is worn and is worn again when outfit is taken off (if applicable)
  • verify o31 intro event works

@ThePotatoGuy ThePotatoGuy added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 24, 2022
@ThePotatoGuy ThePotatoGuy added this to the 0.12.12 milestone Sep 24, 2022
@ThePotatoGuy ThePotatoGuy linked an issue Sep 24, 2022 that may be closed by this pull request
Copy link
Member

@jmwall24 jmwall24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add an ex_prop to toggle the ring off for gloves so we don't have potential clipping

@hatanasinclaire
Copy link

We need to add an ex_prop to toggle the ring off for gloves so we don't have potential clipping

The gloves actually obscure the ring entirely on poses 2, 3, and 5! The position of the ring finger makes it so players would have to have replaced the ring with something extremely wide for it to not be completely covered.

@jmwall24
Copy link
Member

@hatanasinclaire the issue is some players have commissioned rings with stones which is what worries us a bit. Having an ex_prop available for gloves (not just the gloves here, but any gloves) is an easy, safe way of making sure no one ends up with clipping.

o31 costume intro, entry/exit pp, hide-ring exprop
@jmwall24 jmwall24 self-requested a review October 9, 2022 22:12
Copy link
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hatanasinclaire great work on the outfit

@ThePotatoGuy ThePotatoGuy merged commit c1a6e05 into Monika-After-Story:content Oct 29, 2022
@ThePotatoGuy ThePotatoGuy removed awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clothes - 2B
5 participants