Sets variant weights to 0 for now #5527
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shoddd
added
Balance
Shoddd
changed the title
|
I have more reasons why but I need to sleep |
|
Lawful/Justified evil PR |
Shoddd
changed the title
Gw0sty
approved these changes
Feb 19, 2025
monkestation/code/modules/virology/disease/symptom_varients/bluespace.dm
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Sets weight of all variants to 0. Leaving them in game but unobtainable to normal players so they can be readded someday(hopefully) when someone wants to balance them.
I will be updating wiki page if this is merged.
Why It's Good For The Game
Our patho system is ported from VG, variants were not in original VG pathology. They were put in with no rebalancing as it was dropped by borbop for reasons yadadada. Anyways these are pretty cool but currently WAY to busted and they need some pretty heavy rebalancing as well as symptoms themselves to account for the fact they exist.
Its incomplete among unbalanced fixing this is a lot of effort and its been discussed but no one actually has due to that. I agree with a take someone else had on the subject being if no one wants to maintain or fix issues with something codewise, it should be cut, at least for that point.
Honestly, I personally don't see many great ways to balance these out at least the existing variants besides maybe removing virus stacking would help a bit, however if we want to return variants I do think looking at the symptoms themselves is best place to start and this will allow that since you rarely see them without variants used currently.
Plenty of symptoms are good and still worth using without variants, just not busted god heals some are still close but way more balanced, I don't think this is ruining viro/making it pointless/unuseable, keep in mind all these symptoms were originally made without variants in mind.
I think commenting them out until someone wants to fix them is the best move, good motivation for someone.
I'm open to hearing why this isn't best. I do think it is though.
PS. probably gonna rewrite this, wrote most of it last night when I was sleepy, haven't reread yet
Changelog
🆑
removal: variants are unobtainable for now, hopefully not forever
/:cl: