Shipbreaker map template organization #5533
Conversation
LikeLakers2
added
Minor
Mapping
Fix
|
Wooo, CI errors, let's go! |
yes this somehow fixes the hard-del, don't ask me how
LikeLakers2
force-pushed
the
project/map-sorting/shipbreaking
branch
from
4c3054c to
95b6de1
Compare
LikeLakers2
changed the title
_maps/~monkestation/shipbreaking
|
@LikeLakers2 Make sure gorlex cruiser isnt possible to spawn in its too fucking stacked, it should be an emag only ship or something |
|
@ThePooba The gorlex cruiser map template datum was already commented out - and I did not change this, so it's still commented out. |
me when i accidentally make my ship too fucking cool. uhh nuke the revolver and some of the more excessive loot instead of just disabling |
|
@Addust I would rather not, as this PR is only about organizing the shipbreaker map templates, and ensuring they follow the linters. |
|
you may have broken depot shipbreaking |
|
@Addust Turns out I did. It's fixed now. |
| /* | ||
| /datum/map_template/shipbreaker/whale | ||
| name = "Whale" | ||
| template_id = "whale" | ||
| description = "Whale-type description" | ||
| mappath = "_maps/~monkestation/shipbreaking/whale.dmm" | ||
| */ |
There was a problem hiding this comment.
This map template had no datum, so I made a quick and dirty one. However, as I'm unsure if this map template is wanted, I've commenting it out.
About The Pull Request
This PR performs the following tasks on shipbreaker map templates (commits are linked for ease of review):
Moves all shipbreaker maps into the
_maps/~monkestation/shipbreakingfolder, to be consistent with other monke-specific map templates.Condenses all shipbreaker map template datums into one file
Fixes certain shipbreaker map paths that were outright broken
Fixes map linting errors with certain shipbreaker map templates, which were exposed by performing the above tasks. I attempted to do this without affecting loot, and for the most part succeeded - though
mess.dmmhas ever so slightly less bronze to collect now, as I had to remove a wall that was in the same tile as a door.Moves shipbreaker map templates to SSmapping, where many other map templates exist - this incidentally fixes a hard-del issue exposed by the above tasks, too.
Creates a map template datum for
whale.dmm- though commented out, as I'm unsure if it's wanted.Why It's Good For The Game
Maintenance and organization.
Changelog
Below are the user-facing changes only.
🆑MichiRecRoom
fix: Some shipbreaking templates had invalid map paths, and thus it was possible to get a blank ship - this has been fixed.
fix: If you found that this PR broke shipbreaking during its testmerge phase, you'd be right. That's been fixed.
/:cl: