Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning for using MCprep in a version beyond what was tested #509

Closed
wants to merge 2 commits into from

Conversation

StandingPadAnimations
Copy link
Collaborator

This will now warn the user when using MCprep in a version of Blender above the upper cap. This is intended to prevent users from thinking that MCprep won't have issues in new Blender versions.

Currently we warn that we won't provide support for MCprep users using a version above the current upper limit, set at 4.0 for now.

How it looks:
image

This is to be set with the convention laid out in #508 (subject to change), which defines how we should choose the upper version cap for MCprep

This will now warn the user when using MCprep in a version of Blender
above the upper cap. This is intended to prevent users from thinking
that MCprep won't have issues in new Blender versions.

Currently we warn that we won't provide support for MCprep users using a
version above the current upper limit, set at 4.0 for now
@StandingPadAnimations StandingPadAnimations requested a review from a team November 26, 2023 02:46
@TheDuckCow
Copy link
Member

Commented over here, let's discuss on the issue thread and decide what to do here after. Though I expect to at least suggest we keep the code for the notification / alert, even if it's off by default.

@StandingPadAnimations
Copy link
Collaborator Author

With some of the concerned raised in #508, I've now modified the error message to be more encouraging of testing and bug reports
image

@TheDuckCow
Copy link
Member

Ok, ha, interesting it's now aggressive on the side of pushing for feedback. It feels a bit much that it appears on every panel and takes up so much space, and is not dismissible (unlike update notifications).

What about this proposal: What if we make a head start to implementing the "Helpful Horse" panel, which could be the only place both this notification as well as the update notice panel appear?

And, if any notice is present (either this new one OR the update ready notice), then a warning icon appears in the panel header. To be clear, this would thus be a panel separate to the others, but appearing first in order ideally so it's at the top.

Already a plan for v3.6.0, we eventually want things like a "cross-spawner search" and other tips and things to show up there. So, this is perhaps a nice stepping stone.

Finally, on the version, I still don't think we should be that aggressively pushing each time blender updates. It just means that most of the time this notification will always be there (which also means over time, people will start to just ignore it entirely, thus diluting if we ever have other notifications). How about we set it to show two minor versions of blender in the future from some reference point? Let me know your thoughts @StandingPadAnimations

@StandingPadAnimations
Copy link
Collaborator Author

I think we could use LTS releases as reference then, since the second number (as of LTS 2.93) will always be divisible by 3 (and thus easy to detect), as well as any changes to the first number (while Blender doesn't officially follow semantic versioning, the first number does often represent a major breaking release)

Helpful Horse integration would also probably be a better idea, especially as we could also merge the in-Blender report pop-ups as well (which should make it easier for users to use). Bonus if we could have a button to autofill the GitHub bug report form too (like Blender does)

@TheDuckCow
Copy link
Member

(sorry for my delay here, I've been swamped... will get back to this)

@StandingPadAnimations
Copy link
Collaborator Author

Closing this to allow us to start Helpful Horse on a clean slate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants