Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed global user vector #107

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ,

to be tested with user rates...
I removed another global from main, more aligned to rust best practise. Putting here as draft, will look again tomorrow.

@arkanoider arkanoider marked this pull request as ready for review September 8, 2023 08:12
@arkanoider
Copy link
Collaborator Author

Removed some comments, compiles correctly. To be fully tested anyway.

Just MOSTRO_CONFIG remain as static variable.

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@grunch grunch merged commit f24e042 into MostroP2P:main Sep 10, 2023
1 check passed
@arkanoider arkanoider deleted the remove-global-user-vec branch September 11, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants