Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clap #116

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Clap #116

merged 4 commits into from
Sep 20, 2023

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ,

some improvements:

  • Added clap crate for easier management of other parameters from terminal.
  • Removed pretty_env_logger from cargo.toml, we can use just tracing crate.
  • Inserted here from previous draft PR the tracing with less verbosity ( this could be enhanced, but for now it's working )

grunch
grunch approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@grunch grunch merged commit fcef76f into MostroP2P:main Sep 20, 2023
1 check passed
@arkanoider arkanoider deleted the clap branch September 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunch grunch grunch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkanoider @grunch