fix: Update ChaturbateUtils class in utils.py to handle missing "wait" and "tries" details #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes remove the unnecessary exception handling for httpx.ReadError in the ChaturbateClient class. This exception was previously logged and re-raised, but it is now removed from the codebase. Refactor the exception handling in ChaturbateClient to improve code readability and maintainability.
- Move the CLI entrypoint from the `main` function to a new `cli` function. - Reorder the command line options for better readability. - Update the `main` function to call the `cli` function using `asyncio.run`. Refactor the CLI entrypoint in `main.py` to improve code organization and readability.
- Refactored the setup method in the SignalHandler class to set up signal handlers for SIGINT and SIGTERM asynchronously. - Replaced the use of sys.platform with direct calls to add_signal_handler to ensure compatibility across platforms. - Updated the handle_signal method to handle signals asynchronously. - Modified the _shutdown method to only set the stop_future result and cancel tasks if the stop_future is not already done. - Added an await statement before calling _cancel_tasks in the _shutdown method to ensure proper cancellation of tasks.
…" and "tries" details
…igurations The AddCorrelationIDFilter class in logging_config.py was removed as it was no longer being used. Additionally, the logging configurations were updated to handle missing "wait" and "tries" details in the ChaturbateUtils class in utils.py. The signal handling in the SignalHandler class was also refactored. Lastly, the models.py file was updated to validate the next_url as a valid URL.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
===========================================
+ Coverage 99.25% 100.00% +0.74%
===========================================
Files 13 13
Lines 538 532 -6
Branches 44 44
===========================================
- Hits 534 532 -2
+ Misses 2 0 -2
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: