Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#302] Implement useStickyIOS #345

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Apr 30, 2024

#302

Changes

iOS 에서 키보드 입력 시 positon:sticky 인 툴바를 화면안에 유지하기위한 훅 입니다.

Issue

가상 키보드가 올라왔을 때 기대하는 동작: sticky 로 설정된 헤더가 뷰포트 내에 고정되어있고 키보드만 올라옴
iOS: document 전체를 위로(화면밖으로) 밀어버림
issue

Workaround

wrapper 로 감싸고 wrapper가 위로 밀린만큼 오프셋을 줌
solution

적용 예시

RPReplay_Final1714477431.MP4

@2wheeh 2wheeh added the ui Something about UI label Apr 30, 2024
@2wheeh 2wheeh requested review from isutare412 and skgndi12 April 30, 2024 12:43
@2wheeh 2wheeh self-assigned this Apr 30, 2024
Copy link

@2wheeh 2wheeh force-pushed the feature/issue-302/sticky-ios branch from 00e447f to 5373e69 Compare May 1, 2024 05:50
@2wheeh 2wheeh force-pushed the feature/issue-302/sticky-ios branch from 5373e69 to a623f12 Compare May 1, 2024 05:50
Copy link

github-actions bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@2wheeh 2wheeh merged commit be0c445 into develop May 2, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-302/sticky-ios branch May 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants