feat(geom): create Rectangled/f from point (and set to point) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jdrueckert
requested changes
Jan 26, 2021
| } | ||
|
|
||
| /** | ||
| * Set this rectangle to be a clone of <code>source</code>. |
There was a problem hiding this comment.
Suggested change
| * Set this rectangle to be a clone of <code>source</code>. | |
| * Set this rectangle to be a clone of <code>point</code>. |
| @@ -170,6 +192,31 @@ public Rectangled set(Rectangled source){ | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Set this rectangle to be a clone of <code>source</code>. | |||
There was a problem hiding this comment.
I believe this comment needs updating
| /** | ||
| * Set this rectangle to be a clone of <code>source</code>. | ||
| * | ||
| * @param point the coordinate of both minimum and maximum corner |
There was a problem hiding this comment.
This should be in line with the other two. Or rather they with this respectively.
| this.minX = source.minX; | ||
| this.minY = source.minY; | ||
| this.maxX = source.maxX; | ||
| this.maxY = source.maxY; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Set this rectangle to be a clone of <code>source</code>. |
There was a problem hiding this comment.
This comment needs updating.
| } | ||
|
|
||
| /** | ||
| * Set this rectangle to be a clone of <code>source</code>. |
There was a problem hiding this comment.
Suggested change
| * Set this rectangle to be a clone of <code>source</code>. | |
| * Set this rectangle to be a clone of <code>point</code>. |
| @@ -380,11 +407,9 @@ public boolean isValid() { | |||
| /** | |||
| * Compute the rectangle of intersection between <code>this</code> and the given rectangle. | |||
| * <p> | |||
| * If the two rectangles do not intersect, then {@link Float#NaN} is stored in each component | |||
| * of <code>dest</code>. | |||
| * If the two rectangles do not intersect, then {@link Float#NaN} is stored in each component of <code>dest</code>. | |||
There was a problem hiding this comment.
auto-formatting 🙄 I will not go over the unrelated docstrings in this PR.
| @@ -394,11 +419,9 @@ public Rectanglef intersection(Rectanglef other) { | |||
| /** | |||
| * Compute the rectangle of intersection between <code>this</code> and the given rectangle. | |||
| * <p> | |||
| * If the two rectangles do not intersect, then {@link Float#NaN} is stored in each component | |||
| * of <code>dest</code>. | |||
| * If the two rectangles do not intersect, then {@link Float#NaN} is stored in each component of <code>dest</code>. | |||
There was a problem hiding this comment.
same here (unrelated formatting change).
jdrueckert
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by Terasology/PolyWorld#35 (tests).