Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated method 'parameter(String)' #107

Closed
wants to merge 4 commits into from

Conversation

TheMarvelFan
Copy link
Contributor

Fixes issue #101

Removed the method 'parameter(String)' from mappie api/src/commonMain/kotlin/tech/mappie/api/ObjectMappingConstructors.kt
Implementation from both classes, i.e., 'ObjectMappingConstructor' and 'MultipleObjectMappingConstructor' was removed.

Also updated the mappie website changelog for this issue, while naming the version as '0.9.0' and date as 'tbd'

@stefankoppier
Copy link
Collaborator

Great! Thanks for the PR. Could you also remove IDENTIFIER_PARAMETER and it's usage? :)

@stefankoppier stefankoppier added this to the v0.9.0 milestone Sep 28, 2024
@TheMarvelFan
Copy link
Contributor Author

@stefankoppier sure I can do that.
Shall I also update the changelog for this?

…tAFieldTest.kt and replaced it with 'to(String)'
@stefankoppier
Copy link
Collaborator

@stefankoppier sure I can do that.
Shall I also update the changelog for this?

No need, that's the compiler internal reference to the removed api function. So the changelog already reflects that.

Could you give the tests a look? The failing tests are probably calls to the removed parameter function. Those can be replaced by to calls.

@TheMarvelFan
Copy link
Contributor Author

TheMarvelFan commented Sep 28, 2024

already did @stefankoppier

I also removed 'IDENTIFIER_PARAMETER' and its usage in the previous commit, but forgot to mention it there.

Hope that's understandable.

@stefankoppier
Copy link
Collaborator

@TheMarvelFan thanks! We can ignore Sonar, so the PR is good to go.

I will merge this in October, or let you know if there are merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants