Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate vsix build and deploy steps #32

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Separate vsix build and deploy steps #32

merged 4 commits into from
Jan 28, 2024

Conversation

MrOrz
Copy link
Owner

@MrOrz MrOrz commented Jan 28, 2024

We separate vsix build, publish-to-VS marketplace and publish-to-OpenVSX into 3 jobs, so that we can just rerun failed jobs if we forgot to update any of the outdated tokens.

Example:
圖片
https://github.com/MrOrz/vscode-gettext/actions/runs/7683610495

Note: the example is created with skipDuplicate: true. In this PR, I removed skipDuplicate: true because it may hide errors if we forgot to bump versions.

MrOrz added 3 commits January 28, 2024 13:13
- it was added to see if publish steps reads pat and can deploy
- keeping them there will hide errors if we forgot to bump versions, thus remove
@MrOrz MrOrz self-assigned this Jan 28, 2024
@MrOrz MrOrz requested review from toku-sa-n and removed request for toku-sa-n January 28, 2024 05:20
@MrOrz MrOrz requested a review from toku-sa-n January 28, 2024 05:36
Copy link
Collaborator

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrOrz MrOrz merged commit b34f733 into master Jan 28, 2024
2 checks passed
@MrOrz MrOrz deleted the separate-deploy branch January 28, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants