Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the output of msgfmt --statistics in the status bar #33

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

toku-sa-n
Copy link
Collaborator

Partially fixes #4. This prints the counts of total, untranslated, and fuzzy messages.

@toku-sa-n toku-sa-n requested a review from MrOrz February 13, 2024 11:12
@MrOrz
Copy link
Owner

MrOrz commented Feb 13, 2024

Thanks for adding this neat feature! I somehow cannot verify this feature even though I have msgfmt installed.
截圖 2024-02-13 下午11 14 19

I think it would be helpful if we can show some debug log in the output tab in the bottom panel when the updateStsatusBarmItem (or updateStatusBarItem?) cannot show status.

@toku-sa-n toku-sa-n marked this pull request as draft February 14, 2024 00:19
@toku-sa-n
Copy link
Collaborator Author

Thank you for trying! I temporarily added a logging feature to the debug console. Could you retry it?
Also, I'm considering telling users the error via some information box and will implement it later.

@toku-sa-n
Copy link
Collaborator Author

toku-sa-n commented Feb 14, 2024

By the way, here is a working screenshot. You can see "3067 個の翻訳メッセージ, 4685 個のあいまいな翻訳, 2624 個の未訳のメッセージ." (3067 messages, 4685 fuzzy translations, 2624 untranslated messages.) at the bottom.
14-02-2024_09:26:38_screenshot

@MrOrz
Copy link
Owner

MrOrz commented Feb 15, 2024

Thanks for the modification! I can read the error messages in the debug console:
截圖 2024-02-15 上午10 29 02
Seems that the shell environment in VSCode does not pick up msgfmt installed through Homebrew.

The error is also shown here in the status bar:
截圖 2024-02-15 上午10 29 42

In the scenario where msgfmt is not found the environment, I think it would be better if we just console.error without showing it in the status bar. It will be good to merge when the error message does not take up space in the status bar.

@toku-sa-n toku-sa-n marked this pull request as ready for review February 15, 2024 12:06
@toku-sa-n
Copy link
Collaborator Author

Fixed it. Could you try it again?

Copy link
Owner

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The error that msgfmt is not found is shown in Debug Console as expected, without displaying the error on status bar. It's now good to go 👍🏻

@toku-sa-n toku-sa-n merged commit 80746f0 into MrOrz:master Feb 23, 2024
1 check passed
@toku-sa-n toku-sa-n deleted the status branch February 26, 2024 07:36
@GitMensch
Copy link
Collaborator

Even when this is after the fact now - can you please update CHANGELOG.md so people have a clue what's changed between the versions?

@MrOrz
Copy link
Owner

MrOrz commented Mar 24, 2024

I thought it's already included in https://github.com/MrOrz/vscode-gettext/releases

And CHANGELOG.md also points the readers there

@MrOrz
Copy link
Owner

MrOrz commented Mar 24, 2024

Sorry it didn't, let me check why

Edit: I forgot to publish the change. I have just bumped the version (using my another Github account) and published a new version; change log already included in https://github.com/MrOrz/vscode-gettext/releases .

@GitMensch
Copy link
Collaborator

I see.

Changes beyond 0.2.0 please see Github releases https://github.com/MrOrz/vscode-gettext/releases

The issue: this is not rendered in the market places or in the clients using this extension (for vscode: go to extensions settings, then to changes) and doesn't work when working offline either :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats in status bar
3 participants