Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactors #27

Merged
merged 11 commits into from
Nov 7, 2022
Merged

Small refactors #27

merged 11 commits into from
Nov 7, 2022

Conversation

nozwock
Copy link
Contributor

@nozwock nozwock commented Nov 7, 2022 •
edited by MrTanoshii
Loading

Feature

  • Add app name to defines
  • App name gets version from environment

Refactor

  • Rename constants.rs to defines.rs

Misc

  • Clean up comments
  • Clean up imports

MrTanoshii
MrTanoshii requested changes Nov 7, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@MrTanoshii MrTanoshii added the enhancement New feature or request label Nov 7, 2022
@MrTanoshii
Copy link
Owner

Contributes to #3

@nozwock
Copy link
Contributor Author

nozwock commented Nov 7, 2022

Thanks for the better description

@MrTanoshii MrTanoshii merged commit 305dd95 into MrTanoshii:main Nov 7, 2022
@nozwock nozwock deleted the refactors branch November 7, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrTanoshii MrTanoshii MrTanoshii approved these changes

Assignees

@nozwock nozwock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nozwock @MrTanoshii